New profile page

Discuss anything you like here
tomoswald
Posts: 4698
Joined: Mon Jun 06, 2016 7:13 pm

Re: New profile page

Post by tomoswald » Fri Apr 14, 2017 8:19 pm

That may be because it needs to be cached and this will be done dependent on how long ago your last upload was carried out

Only the profile page doesn't work for me on apple safari and thats being worked on

bobedwards
Posts: 143
Joined: Fri Jun 10, 2016 8:17 pm

Re: New profile page

Post by bobedwards » Sat Apr 15, 2017 1:36 am

Loving the new profile page, well done!

tomoswald
Posts: 4698
Joined: Mon Jun 06, 2016 7:13 pm

Re: New profile page

Post by tomoswald » Sat Apr 15, 2017 9:45 am

bobedwards wrote:Loving the new profile page, well done!
Thanks Bob

travel
Posts: 230
Joined: Sat Dec 10, 2016 11:11 am

Re: New profile page

Post by travel » Wed Apr 19, 2017 8:31 pm

123Barso123 wrote:I've noticed a lot of people including myself have a line of code across the top left of the profile page, it looks like it's the album names.
Indeed.

This is caused by the URLs we add in our bios getting used in the meta property="og:description"

The script needs to strip out HTML when adding description to the meta tags.

123Barso123
Posts: 145
Joined: Tue Dec 06, 2016 10:22 pm

Re: New profile page

Post by 123Barso123 » Wed Apr 19, 2017 8:33 pm

travel wrote:
123Barso123 wrote:I've noticed a lot of people including myself have a line of code across the top left of the profile page, it looks like it's the album names.
Indeed.

This is caused by the URLs we add in our bios getting used in the meta property="og:description"

The script needs to strip out HTML when adding description to the meta tags.
Thanks for the explanation

teomanewman
Posts: 134
Joined: Sat Oct 01, 2016 1:21 pm

Re: New profile page

Post by teomanewman » Fri Apr 21, 2017 2:52 pm

PHP strip_tags() ... done ... This meta problem has been around for a long time!

That's just the tip of the iceberg in terms of the `Quality` Toms paying the Devs for .. https://validator.w3.org/nu/?doc=https% ... nap.com%2F
Note the first Error ... it's about caching, because the site is supposed to use HTML5 standards which it doesn't.

Customer conversion will be affected by not addressing these simple 'Shop Front' problems imo

Thinking a bit more about this .. It does open the door to scripting attacks since it simply allows HTML to be added without sanitising input/output.

tomoswald
Posts: 4698
Joined: Mon Jun 06, 2016 7:13 pm

Re: New profile page

Post by tomoswald » Fri Apr 21, 2017 3:10 pm

teomanewman wrote:PHP strip_tags() ... done ... This meta problem has been around for a long time!

That's just the tip of the iceberg in terms of the `Quality` Toms paying the Devs for .. https://validator.w3.org/nu/?doc=https% ... nap.com%2F
Note the first Error ... it's about caching, because the site is supposed to use HTML5 standards which it doesn't.

Customer conversion will be affected by not addressing these simple 'Shop Front' problems imo

Thinking a bit more about this .. It does open the door to scripting attacks since it simply allows HTML to be added without sanitising input/output.
These issues are currently being addressed

travel
Posts: 230
Joined: Sat Dec 10, 2016 11:11 am

Re: New profile page

Post by travel » Mon Apr 24, 2017 12:33 pm

Seems like something of a fix has been put in place so that the HTML entered in Bio doesn't corrupt the Meta Description tag and subsequently break the page layout.

Anyone with HTML in their bio may now want to go back and remove the HTML tags, as the Bio no longer reads well.

Michel
Travel Photography on ClickASnap
Image

teomanewman
Posts: 134
Joined: Sat Oct 01, 2016 1:21 pm

Re: New profile page

Post by teomanewman » Mon Apr 24, 2017 8:44 pm

I still see content with bad meta: e.g https://www.clickasnap.com/i/4trwnhj9n3o1gefv

At least I couldn't upload a <script> tag with redirect :lol: still displays though.

travel
Posts: 230
Joined: Sat Dec 10, 2016 11:11 am

Re: New profile page

Post by travel » Mon Apr 24, 2017 8:59 pm

That's an image page; the HTML entered in image description, I assume.

:mrgreen:

Have you found any more breaks on profile pages?

Michel
Travel Photography on ClickASnap
Image

Post Reply